This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Bump web3-providers-ipc oboe version to 2.1.5 #3661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it does not pack 8 MB of test files in its npm package jimhigson/oboe.js#172
|
@maaktweluit nice, thanks for this PR! would you mind adding an entry in the CHANGELOG.md? |
|
@ryanio Anytime! Thanks for the quick reply! Updated changelog.md and checked the box in the description |
|
Ok this looks good! I realized though that we also need to commit the updated package-lock for web3-providers-ipc. @maaktweluit do you mind adding that? |
frankiebee
suggested changes
Aug 11, 2020
|
@ryanio @frankiebee Yes, will add the |
GregTheGreek
approved these changes
Aug 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
So it does not pack 8 MB of test files in its npm package jimhigson/oboe.js#172
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.